H723ZG support - running into issues

[yetanothercarbot]

Greetings.

I have been following the instructions for adding support for a new variant, trying to add support for the STM32H723ZG. My progress so far can be found in my fork.

So far I have added the linker, set the clock configuration and added the generic configuration to boards.txt. When selecting the generic H723ZGTx option, it compiles and uploads fine to my NUCLEO-H723ZG.

However, I can't make a basic LED blink! I've tried it with all three user LEDs (green: PB0, yellow: PE1, red: PB14). Similarly, I've tried using the Serial port, and similarly failed. I'm not sure how to continue debugging this, so I would appreciate any help on how to continue.

[fpistm]

Hi @yetanothercarbot

Sorry for the delay.
Hard to tell. I've a quick look to your commit. Seems you copy the variant_NUCLEO_H723ZG from the H743?
https://github.com/yetanothercarbot/Arduino_Core_STM32/commit/80976be2c9aacaa50537fcc6b62903fb3e7dbbb5#diff-c0d2c146a5f0e0e8234505531b0d5052efb25f58b5baf6fb9e07fb5ea2b7ef8aR198-R202

So NUM_DIGITAL_PINS is not correct anyway it could not explain the issue.
Maybe the board break in the clock config due to the while(!__HAL_PWR_GET_FLAG(PWR_FLAG_VOSRDY)) {} or in one of the Error_Handler().

/cc @gautierg-st

[yetanothercarbot]

I based the nucleo board definition on H743 board as it seemed to be the most similar, but for the mcu itself I followed the instructions from the wiki. I do appear to have accidentally missed that ifdef, haha. I've been trying to compile it with the generic STM32H723ZG preset I made first though.

[fpistm]

I've made a PR: #1859
I've made some checks and minor fixes.
I think issue come from the clock config as the STLink has an issue with the MCO.
In fact HSE_BYPASS is 8MHz by default using the HSI/2 of the STLink.
I've made some tests and all works.

[fpistm]

[yetanothercarbot]

Wow, that is awesome! I was able to get the blink sketch running on my nucleo board from your branch. Thank you so much.

[fpistm]

Wow, that is awesome! I was able to get the blink sketch running on my nucleo board from your branch. Thank you so much.

Welcome. Thank you too as I've just rework your commits ;)
Let me know if you find any issue.