-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Cannot read property 'tap' of undefined #63
Comments
i have the same problem |
Cheers for raising 🙂 I'm struggling to repro this a bit. I gather it's from plugins that work with the html-webpack-plugin, rather than that plugin working by itself I've pushed a branch repro/html-webpack-plugin that includes a webpack config using html-webpack-plugin. You can see at the moment on that branch if you run Could you modify that branch to reproduce the issue you're talking about? |
Sure.There is my PR: #69 |
Facing the same issue, anyone any luck? |
I have the some problem. create by vue/cli. vue.config.js
|
I also have the same issue. Will be watching this thread :)
|
anyone fixed this problem here? solution and why? |
Nobody. Because this plugin use the ES6 Proxy to watch all of the compile & compilation's hooks, but when we tap a customed hook, it'll not be proxy. |
@jerryOnlyZRJ is there a better approach like proxying the Webpack hooks object for any additions? |
I've been doing some testing and I found that in the
to this:
The test cases in #69 pass, however it does result in a few errors from SMP, like so:
But that definitely represents a step in the right direction. It means we might be able to set us a custom proxy object that can handle custom hooks. |
Any luck with this? Using Vue + Nativescript project, it runs fine when building for ios/native, but fails with the above error on web-build, presuming as html plugin is not used in native builds, but fails as above on web. |
very interesting @tstackhouse - cheers for poking around a bit! Errors like that mean that SMP has seen an "end" event for something, without a corresponding "start" event... Not sure why your change would trigger that 🤔 It's possible those console errors are unrelated, since there is an existing outstanding issue to look at occasional logs of ends but no starts |
I am also facing the same issue while implementing critical css with magento pwa studio.
in above code I am getting |
It seems that can't work with webpack customed hooks such as html-webpack-plugin-before-html-processing in html-webpack-plugin, when we tap these events, the error occurred.
The text was updated successfully, but these errors were encountered: