-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in Webpack 3.1.1.0 #28
Comments
Hey @samrod - thanks for raising :) I'll take a look at this properly tonight, but yeah this looks like a bug in SMP's proxy code |
@stephencookdev I am facing the same issue.
Webpack version - 2.6.0
webpack configuration is fed into the webpack using node js script, where I make some updates in the script.
|
Ahh, okay - I've gotten to the bottom of this now. Thanks for sharing your webpack configs guys, very enlightening Basically the way we're preventing infinite-loops of wrapping is by adding a We should be able to mitigate this by keeping a local reference of wrapped objects, rather than marking the objects themselves. I'll get on a fix for this soon. |
Okay, I've raised #29 which should fix up the issue... Would be great if you guys could check out the branch locally, and just confirm the fix. But if not, I'll deploy tomorrow :) |
Still getting the issue, although it is different one now.
I was able to see the output generated by SMP ( time taken by each module), but after that it got crashed. I will try to look into this issue tonight. |
@guptakvgaurav I think that you've been really unlucky and hit 2 completely independent issues 🤔 I've raised #30 to discuss your second issue - and will resolve this one as complete. |
And my webpack.config.dev.js:
The text was updated successfully, but these errors were encountered: