fix: avoid function properties lost #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add proxy to avoid function properties miss
hanzooo
changed the title
|
Hi @stephencookdev - thanks for maintaining this plugin. In my project, I have validated that this resolves incompatibilities with webpack 5 as well. We are now using a patch from this pull request. Thanks @hanzooo for the fix as well. |
|
This is awesome @hanzooo, thanks for the fix! I've just tested this all works great 🙂 will merge and release something for this now |
sunft1996
pushed a commit
to sunft1996/speed-measure-webpack-plugin-source-read
that referenced
this pull request
Jul 20, 2023
fix: avoid function properties lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #160
The compiler.webpack is a function with some properties, they're lost after call function bind. I use proxy to keep them access.