Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: 'set' on proxy: trap returned falsish for property 'modules' for ModuleConcatenationPlugin #12

Closed
rnaud opened this issue Feb 13, 2018 · 3 comments

Comments

@rnaud
Copy link

rnaud commented Feb 13, 2018

Hello again :)
Here is another issue I encountered when running this plugin using ModuleConcatenationPlugin

Full stacktrace:

/Users/anf/projects/my_app/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:181
        compilation.modules = compilation.modules.filter(m => !usedModules.has(m));
                            ^

TypeError: 'set' on proxy: trap returned falsish for property 'modules'
  at Proxy.compilation.plugin (/Users/anf/projects/my_app/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:181:25)
  at Compilation.wrappedFunc (/Users/anf/projects/my_app/node_modules/speed-measure-webpack-plugin/WrappedPlugin/index.js:13:24)
  at Compilation.applyPluginsBailResult (/Users/anf/projects/my_app/node_modules/tapable/lib/Tapable.js:129:27)
  at sealPart2 (/Users/anf/projects/my_app/node_modules/webpack/lib/Compilation.js:613:10)
  at Compilation.applyPluginsAsyncSeries (/Users/anf/projects/my_app/node_modules/tapable/lib/Tapable.js:195:46)
  at Compilation.seal (/Users/anf/projects/my_app/node_modules/webpack/lib/Compilation.js:605:8)
  at applyPluginsParallel.err (/Users/anf/projects/my_app/node_modules/webpack/lib/Compiler.js:504:17)
  at /Users/anf/projects/my_app/node_modules/tapable/lib/Tapable.js:289:11
  at _addModuleChain (/Users/anf/projects/my_app/node_modules/webpack/lib/Compilation.js:507:11)
  at processModuleDependencies.err (/Users/anf/projects/my_app/node_modules/webpack/lib/Compilation.js:477:14)
  at process._tickCallback (internal/process/next_tick.js:150:11)
@stephencookdev
Copy link
Owner

Thanks for raising :)

I'm fairly sure this is the same issue as #10 but will check tomorrow morning

@stephencookdev
Copy link
Owner

So this should have fixed the issue: #13

Let me know :)

@rnaud
Copy link
Author

rnaud commented Feb 14, 2018

I can confirm this is fixed, thank you for the very fast turn around!

@rnaud rnaud closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants