Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_MODBUSINO_RTU_MAX_ADU_LENGTH is wrong #6

Closed
karlp opened this issue Dec 9, 2014 · 1 comment
Closed

_MODBUSINO_RTU_MAX_ADU_LENGTH is wrong #6

karlp opened this issue Dec 9, 2014 · 1 comment

Comments

@karlp
Copy link
Contributor

karlp commented Dec 9, 2014

I started using rather larger modbus tables, and starting hitting all sorts of buffer overflows :( (I have a very old fork, that was missing some of the earlier fixes for this)

But immediately, the define for RTU_MAX_ADU is just wrong. Setting this to 256 properly, as per page 5 of modbus app proto 1.1b3 results in requests for more than 64 registers succeeding, but requesting 128 registers for instance, passes validation but overflows. I know this is the "very very very cut down" version, so I'm not hanging out for a heap of fixes, just letting you know.

@stephane
Copy link
Owner

stephane commented Apr 5, 2019

OK thank you for your report. I'll just leave a comment about that in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants