Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Switch from lib/pq to pgx postgres library #4402

Open
paulbellamy opened this issue May 24, 2022 · 1 comment
Open

services/horizon: Switch from lib/pq to pgx postgres library #4402

paulbellamy opened this issue May 24, 2022 · 1 comment
Labels
feature request

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented May 24, 2022 •
edited
Loading

Seems like, pgx solves a few bugs in lib/pq, and offers some possibilities for performance improvements (e.g. CopyFrom for bulk insertions).

In particular, pgx seems to have better timeout enforcement. (#4392)

Note: BeginEx method for pgx, doesn't autorollback, so we can pass a context to it as well. 👍

See previous work on this: #3342
This was referenced May 24, 2022
Closed
Closed
@paulbellamy
Copy link
Contributor Author

This is low priority, given #4390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulbellamy