Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Update codebase to conform to new XDR types #4260

Closed
3 tasks done
Tracked by #409
Shaptic opened this issue Mar 7, 2022 · 0 comments
Closed
3 tasks done
Tracked by #409

all: Update codebase to conform to new XDR types #4260

Shaptic opened this issue Mar 7, 2022 · 0 comments
Assignees
Labels
Protocol 19 Support cap-21, cap-40 and sep-23 in Horizon & SDKs

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Mar 7, 2022

Breakdown and Rollout: Horizon & Protocol 19. See #4261 for the master issue.


CAP-21 introduces a change to how time is represented in the protocol and it also changes the way you access transaction preconditions. The relevant changes are described in the XDR diff. When a project starts using the updated XDR, it must first be updated to conform to the new predicate time types as well as the new way transaction conditions are accessed. In summary,

  • relBefore is a Duration rather than an Int64
  • absBefore is a TimePoint rather than an Int64
  • timebounds preconditions are accessed via tx.Cond.TimeBounds rather than tx.TimeBounds
  • similarly, transactions w/ timebounds should be constructed on the Cond field with the PreconditionTypePrecondTime type
@Shaptic Shaptic assigned Shaptic and unassigned Shaptic Mar 7, 2022
@Shaptic Shaptic changed the title Update claimable balances to use time structures over raw timestamps in SDKs Meta: Update claimable balances to use structures over timestamps in SDKs Mar 7, 2022
@Shaptic Shaptic changed the title Meta: Update claimable balances to use structures over timestamps in SDKs Update claimable balances to use structures over timestamps in SDKs Mar 7, 2022
@Shaptic Shaptic added the Protocol 19 Support cap-21, cap-40 and sep-23 in Horizon & SDKs label Mar 7, 2022
@Shaptic Shaptic self-assigned this Mar 7, 2022
@Shaptic Shaptic changed the title Update claimable balances to use structures over timestamps in SDKs all: Update codebase to conform to new XDR types Mar 14, 2022
@Shaptic Shaptic closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol 19 Support cap-21, cap-40 and sep-23 in Horizon & SDKs
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant