Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous benchmarking #4237

Open
2opremio opened this issue Feb 21, 2022 · 0 comments
Open

Add continuous benchmarking #4237

2opremio opened this issue Feb 21, 2022 · 0 comments

Comments

@2opremio
Copy link
Contributor

What problem does your feature solve?

Performance degradations caused by code changes can be subtle in their cause and go unnoticed.

For instance, in #4178 @paulbellamy and I had to carefully manually run benchmarks which we did

Adding a CI job which compares the Go benchmark results of master against the changes being proposed in a PR will help detect degradations early.

What would you like to see?

A tool like https://github.com/knqyf263/cob integrated in our CI. The tool allows erroring when certain amount of degradation (e.g. 50% worse) is detected.

What alternatives are there?

I am sure there are other tools to do this.

@2opremio 2opremio changed the title Add continuous benchmarking to stellar/go Add continuous benchmarking Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant