fix(group-chat): Missing group chat name when clearing chat history #21684
+21
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmotta
commented
Nov 26, 2024
| :empty-chat? | ||
| (not (:last-message current-chat))))) | ||
| (fn [chat] | ||
| {:able-to-send-message? (:able-to-send-message? chat) |
There was a problem hiding this comment.
In mobile apps using CLJS I prefer to reserve select-keys only for cases where the list of keys is dynamic. Here we know the fixed set of keys, so I extract directly. Destructuring made the code look longer because the destructured keys span over multiple lines, plus the returned map.
There was a problem hiding this comment.
We know select-keys and merge are expensive operations, so this change makes a lot of sense 👍
Jenkins BuildsClick to see older builds (4)
|
Parveshdhull
approved these changes
Nov 26, 2024
acc6321
to
b19b559
Compare
88% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
|
88% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (7)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
b19b559
to
100a26a
Compare
|
@ilmotta Thank you for your PR!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21639
Summary
Fix missing group name when user chooses drawer option to clear chat history from within the group chat screen.
Areas that may be impacted
Chat option to clear history.
Steps to test
Please refer to the reproduction steps specified in the issue. With the fix applied, you should see the group chat name in the drawer when you try to clear the history from the list of group chats and from within each group chat options drawer.
status: ready