Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to attach image to message #20510

Open
igor-sirotin opened this issue Jun 19, 2024 · 30 comments
Open

Crash when trying to attach image to message #20510

igor-sirotin opened this issue Jun 19, 2024 · 30 comments

Comments

@igor-sirotin
Copy link
Contributor

Problem

Reproduce steps:

  1. Go to Status Community -> #mobile
  2. Press "attach image" button
RPReplay_Final1718807130.MP4

Acceptance Criteria

No crash. Able to attach an image.

Info

Device: iPhone 14 Pro
OS: iOS 17.5.1

App version: 2.29.20425 (20240617141826)
App commit: c20a2da
Node version: StatusIM/v0.180.30/ios-arm64/go1.21.8

@ilmotta
Copy link
Contributor

ilmotta commented Jun 19, 2024

For anyone going to investigate this issue, I couldn't reproduce on Android 13 on a real device and when pointing to the revision reported in this issue c20a2da. Possibly an iOS-only bug.

@status-im/mobile-qa, whenever possible, could you check if you can reproduce this bug in other devices or is it only affecting this particular version of iOS?

@pavloburykh
Copy link
Contributor

Hey @ilmotta! Not reproducing on my iPhone X, IOS 16.7.7

@VolodLytvynenko
Copy link
Contributor

Hi. Can't reproduce it on iPhone 11 Pro max, IOS 17.5

crash.mp4

@mariia-skrypnyk
Copy link

Hey hey @ilmotta !

Did the exact steps on nightly and no crash.
Tried on my iPhone 13 (17.5.1).

@igor-sirotin
Copy link
Contributor Author

Thanks you for checking!
I'm still able to reproduce it every time. Let me know if I should gather any details for you.
I guess I can get a crash dump somehow?

@qoqobolo
Copy link
Contributor

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

@igor-sirotin
Copy link
Contributor Author

igor-sirotin commented Jun 20, 2024

I tried to limit photos access to 1 image and it's working. Also doesn't crash with no photo access.

But still crashes when going back to Full access to my 9k photos and 1,5k videos.

@igor-sirotin
Copy link
Contributor Author

igor-sirotin commented Jun 20, 2024

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

yes 🙂
But it doesn't seem related in any way

@qoqobolo
Copy link
Contributor

Hey @igor-sirotin, thanks for reporting! Do you have your mobile app synced with desktop?

yes 🙂 But it doesn't seem related in any way

yeah I see now it's most likely related to permissions/some specific media in your gallery 👌

@churik
Copy link
Member

churik commented Jun 24, 2024

for the record, also not reproducible for me
Device: iPhone 14 Pro
OS: iOS 17.5.1
IMAGE 2024-06-24 17:02:55

I put low-prioso far, as no clue how to get the issue

@igor-sirotin
Copy link
Contributor Author

lol, what is it in my photo library 😄

@ilmotta
Copy link
Contributor

ilmotta commented Jun 24, 2024

@igor-sirotin, let's give some more time for this issue to pop-up again from other users. I'm sorry to see we can't help yet.

The only other idea I can think of now is if you tried to develop the mobile app against your real device to better debug the error, but that's a whole lot to digest 😄 But if you want to venture yourself in the darkness of status-mobile let us know and we can try to help.

@igor-sirotin
Copy link
Contributor Author

let's give some more time for this issue to pop-up again from other users. I'm sorry to see we can't help yet.

The only other idea I can think of now is if you tried to develop the mobile app against your real device to better debug the error, but that's a whole lot to digest 😄 But if you want to venture yourself in the darkness of status-mobile let us know and we can try to help.

@ilmotta, no worries, thank you!
I'll be ready to debug this at some point later 🙂

@flexsurfer
Copy link
Member

we are loading images with

[rn/image
      {:source {:uri (:uri item)}
       :style  (style/image window-width index)}]
       ```
       so most likely something wrong with the image, corrupt or something? not supported format might be

@flexsurfer
Copy link
Member

hey @igor-sirotin please try this one #20574

@flexsurfer
Copy link
Member

flexsurfer commented Jun 26, 2024

thanks Igor, so now we know it's not the image rendering, the error happens in the second request for cameraroll/get-photos

@J-Son89
Copy link
Contributor

J-Son89 commented Jul 25, 2024

@flexsurfer is this issue still present?

@ilmotta
Copy link
Contributor

ilmotta commented Jul 25, 2024

I'm removing the issue from the 2.30 milestone due to the difficulty in reproducing, in combination with our time constraints for the upcoming 2.30 release.

Thank you QA team for trying to promptly investigate the bug.

@igor-sirotin, we will still keep a close eye on this issue if more users report this bug because crashes are no fun. Thanks for reporting and trying to help us figure out the root cause.

@ilmotta ilmotta removed this from the 2.30.0 Beta milestone Jul 25, 2024
@churik churik added the crash label Aug 12, 2024
@ulisesmac ulisesmac assigned ulisesmac and unassigned ulisesmac Sep 25, 2024
@ilmotta
Copy link
Contributor

ilmotta commented Oct 3, 2024

Update: another user reported in Sep 27 a similar bug. Reference https://www.notion.so/Testing-it-1118f96fb65c808c97bcc04c1b3ce214

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Oct 4, 2024

Reproduced this issue on: iPhone 16 IOS: 18.0
https://app.eu-central-1.saucelabs.com/tests/0a5612ad034445c7b011636ce359a831

logs:
SauceLabs_Log_iPhone_16_18_real_2024-10-04_03-58.txt

@VolodLytvynenko VolodLytvynenko added this to the 2.32.0 Beta milestone Oct 4, 2024
@VolodLytvynenko
Copy link
Contributor

@ilmotta @churik I've moved this issue to the 2.32 Milestone because I think it's device or OS specific. I've tested it on 5 iOS devices and was only able to reproduce it on an iPhone 16 on iOS 18, although the user reported it on a different device. I'm mentioning it here in case it needs to be included in 2.31. Feel free to move it to 2.31 if you think it has a higher priority to be fixed

@ilmotta
Copy link
Contributor

ilmotta commented Oct 4, 2024

@VolodLytvynenko I guess most people, like myself, outside the QA team can't access SauceLabs, so we can't watch the video.

If we solve this issue, it will definitely be for 2.32 or beyond. Thanks for updating the issue.

@flexsurfer
Copy link
Member

flexsurfer commented Oct 4, 2024

@VolodLytvynenko maybe the problem is not in the device or OS, but in the data or some kind of image, or there is probably an edge case, could you experiment with the device there you have crash and try to avoid it, idk, change gallery images etc

@ulisesmac
Copy link
Contributor

@VolodLytvynenko Probably you can privately share with us the photo you trid to send as a file and we can try replicating the issue, or you could try the same photo on different devices.

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Oct 14, 2024

@VolodLytvynenko Probably you can privately share with us the photo you trid to send as a file and we can try replicating the issue, or you could try the same photo on different devices.

@ulisesmac Unfortunately, I can't reproduce this issue anymore and can't share the photo because I was using a Sauce Labs device when the crash occurred. Currently, I am unable to reproduce the issue on the same device and iOS version. I can only share the Sauce Labs recording, but there doesn't seem to be anything unusual in my steps:

  1. Finished onboarding (1:03)
  2. Took a photo using the device camera (1:15)
  3. Sent the photo in a 1-1 chat, which caused the crash (2:21)
video.mp4

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Oct 14, 2024

Here are some additional logs that Sauce Labs can provide
https://www.dropbox.com/scl/fi/fdzhkxn1ijfjfn1lb1cm9/device-1.log?rlkey=833taj3sp8xuqhimi1bhbmo0c&st=ra76vvxe&dl=0

@ilmotta ilmotta removed the bug label Oct 14, 2024
@flexsurfer
Copy link
Member

hm @VolodLytvynenko it seems like it is another issue, in the current task crash happened when trying to attach image, not send

@flexsurfer
Copy link
Member

they might be related but we don't know that, I would register it as a separate issue

@igor-sirotin
Copy link
Contributor Author

I still can reproduce every time.
If someone wants to help me set up debugging with my phone, feel free to reach out to me, I'can be your hands to do debugging 🙂

@churik
Copy link
Member

churik commented Nov 26, 2024

I don't think that we have a capacity for it in 2.32, given the desired release cut date
Deferring the issue, please be free to move it bak if you think there is a room for it @ilmotta

@churik churik modified the milestones: 2.32.0, 2.33.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests