Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicators on Share Wallet screen go beyond the edges of the screen #18630

Open
mariia-skrypnyk opened this issue Jan 25, 2024 · 5 comments
Open

Indicators on Share Wallet screen go beyond the edges of the screen #18630

mariia-skrypnyk opened this issue Jan 25, 2024 · 5 comments
Labels
wallet-core Issues for mobile wallet team

Comments

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Jan 25, 2024 •
edited
Loading

Bug Report

#18523

Problem

Expected behavior

Indicators on Share Wallet screen feet the screen and looks as designed that is going to appear according to this.

Actual behavior

Indicators on Share Wallet screen go beyond the edges of the screen
photo_2024-01-25_15-56-30

Reproduction

  1. Login to Status app
  2. Go to Wallet
  3. Creat 23 more accounts
  4. Go to Share->Wallet

Additional Information

  • Status version: PR
  • Operating System: Android, iOS
@mariia-skrypnyk mariia-skrypnyk added this to the 1.27.0 - Alpha milestone Jan 25, 2024
@mariia-skrypnyk mariia-skrypnyk mentioned this issue Jan 25, 2024
Merged
@J-Son89
Copy link
Contributor

J-Son89 commented Feb 22, 2024

This issue depends on this issue being completed first: #18942

@cammellos cammellos removed this from the 2.27.0 Alpha milestone Mar 14, 2024
@J-Son89
Copy link
Contributor

J-Son89 commented Jun 12, 2024

designs
https://www.figma.com/design/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=8728-6921&t=lKTDFX5Hu7ErDsuc-4

@J-Son89
Copy link
Contributor

J-Son89 commented Jun 12, 2024

how it should look:
https://github.com/status-im/status-mobile/assets/22799766/6d460281-d1e1-457f-a78f-4fdc3e3f8650

@ilmotta
Copy link
Contributor

ilmotta commented Jul 2, 2024

@J-Son89 As this issue is more under the umbrella of wallet teams, I'm removing the mobile-core label and adding mobile-wallet-core.

@ilmotta ilmotta added wallet-core Issues for mobile wallet team and removed mobile-core labels Jul 2, 2024
@shivekkhurana shivekkhurana added this to the 2.31.0 Beta milestone Oct 3, 2024
@churik churik removed this from the 2.31.0 Beta milestone Oct 3, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Nov 19, 2024
@mohsen-ghafouri
Copy link
Contributor

mohsen-ghafouri commented Nov 20, 2024 •
edited
Loading

@churik is it still blocked? i can see we have design for it https://www.figma.com/design/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=8728-6921&t=lKTDFX5Hu7ErDsuc-4

CC @shivekkhurana

@mohsen-ghafouri mohsen-ghafouri removed their assignment Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ilmotta @cammellos @shivekkhurana @churik @J-Son89 @siddarthkay @mohsen-ghafouri @mariia-skrypnyk