Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receipts propagation to the local testnet tests and add call to test this #977

Closed
3 tasks done
kdeme opened this issue Feb 23, 2022 · 2 comments
Closed
3 tasks done

Comments

@kdeme
Copy link
Contributor

kdeme commented Feb 23, 2022

Just as was done for block headers and block bodies, now receipts should be shared around and accessible via json-rpc API.

We don't currently have them in the data set. Items to be done here are:

  • Create a new block data dump in the format of rlp encoded [header, [txs, uncles], receipts]
  • Add receipts to the propagation (this is mostly prepared)
  • Get a json rpc eth call to test this: eth_getTransactionReceipt would be the typically used one for this, however this needs a mapping from tx hash to block has, which we don't have and which I assume the "Canonical Indices Network" is supposed to provide. Perhaps we can temporary create a debug json rpc call that requests it by block hash + tx number or similar.
    Edit: New suggestion from @KonradStaniec is to use/implement getLogs but only with blockhash as filter (partial implementation).
@kdeme
Copy link
Contributor Author

kdeme commented Jun 15, 2022

Point 1 and 2 were done in #1115 and #1118

@kdeme
Copy link
Contributor Author

kdeme commented Jul 8, 2022

getLogs was added in fdb048e and is tested in the local testnet script

@kdeme kdeme closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant