fixes crappy custom genesis and chain config parser #654
Conversation
instead of using stdlib/json, now we switch to json_serialization the result is much tidier code and more robust when parsing optional fields. fixes #635
this changes is required due to recent #654. custom genesis and chain config parser are fixed and the genesis fields are grouped into "genesis" field, similar with chain config fields, they are grouped in "config" field.
this changes is required due to recent #654. custom genesis and chain config parser are fixed and the genesis fields are grouped into "genesis" field, similar with chain config fields, they are grouped in "config" field.
|
Nice code. Very clear. Smaller than the code it replaces too. Lots of deletions, often a good sign 🙂 Why does it fix so many Hive testcases. Was it just the #635 Where did you get the new JSON testcase files? We have a lot of test files that are, in effect, like compiled binaries with no source code. (E.g. because of EVM bytecode, etc). So I often wonder where they came from, or how to generate them. |
The old code although not produce The new code will handle any optional/missing fields. it will fill those missing fields with correct number to avoid wrong fork calculation.
I copy them from hive output. |
instead of using stdlib/json, now we switch to json_serialization
the result is much tidier code and more robust when parsing
optional fields.
fixes #635