Shell: Update help text to match reality #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capitalisation: - The option is lower case `--logmetrics` but help said `--logMetrics` - Same for `--logmetricsiterval` - Same for `--metricsserver` and `--metricsserverport` Ethereum network selection: - Moved out into their own, cleaner help section - Added help for `--mainnet`, `--goerli` and `--kovan` - Moved `--networkid` and `--customnetwork` to this section as well Other: - Reworded or formatted some help lines for clarity and consistency Changed options: - Renamed `--metricserver` to `--metrics` - Renamed `--matricsserverport` to `--metricsport` - Removed Morden network; this didn't have an option, but could be selected with `--networkid:2` and then fail to work Signed-off-by: Jamie Lokier <[email protected]>
Morden network has not had a working configuration in Nimbus for a few years, so it's been removed form the main program. Remove it from premix as well. Signed-off-by: Jamie Lokier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capitalisation:
--logmetricsbut help said--logMetrics--logmetricsiterval--metricsserverand--metricsserverportEthereum network selection:
--mainnet,--goerliand--kovan--networkidand--customnetworkto this section as wellOther:
Changed options:
--metricserverto--metrics--matricsserverportto--metricsportselected with
--networkid:2and then fail to workSigned-off-by: Jamie Lokier [email protected]