Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to implement JournalDB and beam sync in AccountStateDB #422

Closed
7 tasks
jangko opened this issue Nov 19, 2019 · 1 comment
Closed
7 tasks

Need to implement JournalDB and beam sync in AccountStateDB #422

jangko opened this issue Nov 19, 2019 · 1 comment

Comments

@jangko
Copy link
Contributor

jangko commented Nov 19, 2019

Both GeneralStateTest and BlockChainTest now turned off state trie pruning when running tests.
With the introduction of EIP2200, some tests will fail if we turn on state trie pruning.

We cannot longer evade the need to implement a JournalDB.
I did not implement the JournalDB during EIP2200 implementation because we need not only a JournalDB, but also an AccountStateDB that can have beam sync turned on.
in the end the new AccountStateDB should have this features:

  • taking state snapshot
  • revert/rollback to old state by some ID/version
  • discard snapshot
  • able to jump back to historical state by ID/version and then jump forward during transaction execution with or without state trie pruning.
  • turn state trie pruning on/off
  • storage trie also have their own virtual container without depend on state trie pruning turned off
  • turn beam sync on/off
@jangko
Copy link
Contributor Author

jangko commented Jul 19, 2022

we have a working AccountsCache that works similar to the JournalDB. beam sync is not relevant anymore. closing

@jangko jangko closed this as completed Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant