Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check stack usage (other than EVM) #413

Open
mratsim opened this issue Nov 10, 2019 · 2 comments · Fixed by #586, #588 or #598
Open

Check stack usage (other than EVM) #413

mratsim opened this issue Nov 10, 2019 · 2 comments · Fixed by #586, #588 or #598
Labels

Comments

@mratsim
Copy link
Contributor

mratsim commented Nov 10, 2019

As shown by status-im/nimbus-eth2#370 (comment), putting too much data on the stack will have serious impact on the GC as it scans it to find live objects (100x slowdown).

It seems like libsecp256k1 uses the stack a lot as well. The dependency should be updated after bitcoin-core/secp256k1#692 is fixed.

@gmaxwell
Copy link

bitcoin-core/secp256k1#692 only applies to a weird non-defaultconfiguration that I expect nothing is actually using. The library doesn't otherwise use a large amount of information on the stack

@jlokier
Copy link
Contributor

jlokier commented Apr 27, 2021

The stack-scanning done by Nimbus GC does affect nimbus-eth1 when the EVM runs and uses a lot of stack.
Recent changes (shown above) have fixed stack usage in the EVM, so this is no longer a problem.

There may be other causes of substantial stack use, e.g. I haven't checked if libsecp256k1 does, mentioned above.
Therefore keeping this issue open until that's been checked.

@jlokier jlokier reopened this Apr 27, 2021
@jlokier jlokier changed the title Stack usage Check stack usage (other than EVM) Apr 27, 2021
@jangko jangko added the EL label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment