Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory consumption #401

Closed
jangko opened this issue Oct 7, 2019 · 5 comments
Closed

Reduce memory consumption #401

jangko opened this issue Oct 7, 2019 · 5 comments

Comments

@jangko
Copy link
Contributor

jangko commented Oct 7, 2019

The memory usage stat is here.

The interesting part is AsyncFD. Both Blockchain test and GeneralState test does not using anything async. Where does it come from?

EDIT: scroll the stat table to the right if you want to see the alloc freq and avg size.

@arnetheduck
Copy link
Member

the is/was a bug in chronos that would initialize things only from importing them, could that be it? status-im/nim-chronos#46

@arnetheduck
Copy link
Member

@cheatfate

@cheatfate
Copy link
Contributor

The only place where we using KeyValuePairSeq is HashSet, which is used only for Windows and usage is pretty simple. We using it only for checking if AsyncFD is already registered in queue, because on Windows its hard to obtain such information.
https://github.com/status-im/nim-chronos/blob/master/chronos/asyncloop.nim#L365-L370

@jangko could we get not only Windows memory consumption?

@jangko
Copy link
Contributor Author

jangko commented Oct 12, 2019

I already updated the mem stat here.

new columns are: deallocSize, deallocFreq, unfreed

also add mem stat from macosx and linux.

a stat of @cheatfate test code.

the mysterious AsyncFD is still there although metrics already turned off.

@jangko
Copy link
Contributor Author

jangko commented Feb 19, 2020

fixed by #441 and #442, closing

@jangko jangko closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants