Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing generalStateTest from CI #379

Closed
3 tasks done
jangko opened this issue Aug 17, 2019 · 1 comment
Closed
3 tasks done

missing generalStateTest from CI #379

jangko opened this issue Aug 17, 2019 · 1 comment

Comments

@jangko
Copy link
Contributor

jangko commented Aug 17, 2019 •
edited
Loading

during march 19-20 features addition of test_generalstate_json.nim, I accidentally made GST disappeared from CI log. And because we are not aware of this situation, many new 32 bit GST failed during byzantium and constantinople implementation.

I already know whats wrong. but I open this issue to remind myself of related TODOs:

  • make GST appear in CI again
  • remove old 32 bit failed GST from skip list if it already fixed
  • include new 32 bit failed GST into skip list
@jangko
Copy link
Contributor Author

jangko commented Aug 20, 2019

fixed by #380, closing

@jangko jangko closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jangko