Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urgent need to refactor contract call and contract creation #248

Closed
jangko opened this issue Feb 26, 2019 · 0 comments · Fixed by #252
Closed

urgent need to refactor contract call and contract creation #248

jangko opened this issue Feb 26, 2019 · 0 comments · Fixed by #252

Comments

@jangko
Copy link
Contributor

jangko commented Feb 26, 2019

for each contract/message call and contract creation, we have 3 distinct implementation:

  1. in general state test
  2. in processTransaction
  3. in opcode impl/computation impl

This lead to confusion and hard to reason code when bugs detected.
Current problematic block 652.148, reveal this bad design clearly.
The problem itself is simple, but the solution is not simple.

We should merge those 3 distinct implementations soon, before it become too complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant