Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake vs Real STOP Opcode #235

Closed
jangko opened this issue Feb 19, 2019 · 0 comments
Closed

Fake vs Real STOP Opcode #235

jangko opened this issue Feb 19, 2019 · 0 comments

Comments

@jangko
Copy link
Contributor

jangko commented Feb 19, 2019 •
edited
Loading

Our current implementation will insert a STOP opcode at the end of code stream if the code stream doesn't terminated with STOP opcode.

During code execution this fake STOP will not do anything harm, it will stop code execution as expected. But it is harmful for the tracer. The transaction tracer will produce wrong tracing result.

We need to distinguish a real STOP and a fake STOP if we want to produce a reliable tracing result.

example block: 81383
jangko added a commit to jangko/nimbus-eth1 that referenced this issue Feb 22, 2019
@jangko
fixes status-im#235
0e92d83
@zah zah closed this as completed in 28245e9 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jangko