Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API getPayload handlers don't check for too-new forks #2252

Closed
tersec opened this issue May 30, 2024 · 0 comments
Closed

Engine API getPayload handlers don't check for too-new forks #2252

tersec opened this issue May 30, 2024 · 0 comments

Comments

@tersec
Copy link
Contributor

tersec commented May 30, 2024

It does check

let payload = payloadGeneric.V3
let com = ben.com
if not com.isCancunOrLater(ethTime payload.timestamp):
raise unsupportedFork("payload timestamp is less than Cancun activation")

let payload = payloadGeneric.V4
let com = ben.com
if not com.isPragueOrLater(ethTime payload.timestamp):
raise unsupportedFork("payload timestamp is less than Prague activation")

i.e. whether one tries to send an engine_newPayloadV3 with a payload from before Cancun starts, or engine_newPayloadV4 with a payload from before Prague begins, but it does not check whether one sends an engine_newPayloadV3 with payload with a timestamp within Prague.

https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/cancun.md#update-the-methods-of-previous-forks states:

For the following methods:

a validation MUST be added:

  1. Client software MUST return -38005: Unsupported fork error if the timestamp of payload or payloadAttributes greater or equal to the Cancun activation timestamp.

and similarly
https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/prague.md#update-the-methods-of-previous-forks states:

For the following methods:

a validation MUST be added:

  1. Client software MUST return -38005: Unsupported fork error if the timestamp of payload or payloadAttributes greater or equal to the Prague activation timestamp.
@tersec tersec changed the title Engine API newPayload handlers don't check for too-new forks Engine API getPayload handlers don't check for too-new forks May 30, 2024
@tersec tersec closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant