Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated rpc types or web3 duplicates #1913

Closed
jangko opened this issue Nov 28, 2023 · 1 comment
Closed

Outdated rpc types or web3 duplicates #1913

jangko opened this issue Nov 28, 2023 · 1 comment
Labels
refactoring RPC JSON-RPC over HTTP/websocket

Comments

@jangko
Copy link
Contributor

jangko commented Nov 28, 2023

Notable duplicates from web3 are ReceiptObject, BlockObject, TransactionObject, and so on.

Also both RPC and web3 use different types for the same field in above mentioned objects.

Need to clean up this messy arrangement.
@jangko jangko added RPC JSON-RPC over HTTP/websocket refactoring labels Nov 28, 2023
@jangko jangko mentioned this issue Dec 12, 2023
Closed
@jangko
Copy link
Contributor Author

jangko commented Dec 13, 2023

fixed by #1937, closing

@jangko jangko closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring RPC JSON-RPC over HTTP/websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump nim-web3: remove rpc types duplicates status-im/nimbus-eth1
1 participant
@jangko