Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure path of traceContentLookup is not implemented #1905

Closed
kdeme opened this issue Nov 24, 2023 · 1 comment
Closed

Failure path of traceContentLookup is not implemented #1905

kdeme opened this issue Nov 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Fluffy

Comments

@kdeme
Copy link
Contributor

kdeme commented Nov 24, 2023

Noticed this when running glados with a Fluffy node. It provides no trace path of the lookup when it failed finding the content:
image

Appears not to be implemented: https://github.com/status-im/nimbus-eth1/blob/master/fluffy/network/wire/portal_protocol.nim#L1281

@kdeme kdeme added Fluffy bug Something isn't working labels Nov 24, 2023
@mynameisdaniil mynameisdaniil self-assigned this Nov 24, 2023
@kdeme
Copy link
Contributor Author

kdeme commented Dec 4, 2023

Fixed in #1908

@kdeme kdeme closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fluffy
Projects
None yet
Development

No branches or pull requests

2 participants