Failed validating block body - Invalid ommers hash

[kdeme]

Our testnet fleet has quite a spam of this warning:

WRN 2023-09-12 11:22:13.860+00:00 Failed validating block body               topics="portal_hist" error="Invalid ommers hash"

These are incoming block bodies through offer/accept/utp flow. They are probably coming from a Trin bridge + Trin node.

However, recently added portal-hive tests hit this issue also for post cappella blocks. So it is easily reproducible in portal-hive by running portal-interop simulator:

./hive --sim portal-interop --client fluffy

The strange thing there is that the issue only occurs on gossip tests and not on raw offer testing.

[kdeme]

First thing to investigate here should probably be checking the decoded post Shanghai block its uncles field.
We do a check here if it is empty or not: https://github.com/status-im/nimbus-eth1/blob/master/fluffy/network/history/history_network.nim#L246

[kdeme]

I just realised that the uncles field in the PortalBlockBodyShanghai is a ByteList holding the rlp encoded uncles.
That len() check there assumed checking the actually array I believe, hence this is faulty, but easy to fix.

Still strange that portal-hive offers work but gossip fails. Something seems wrong there too.

We also should have this tested better locally.

[kdeme]

Fixed in #1756