Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup web3/rpc/eth type converters #1694

Closed
9 tasks
jangko opened this issue Aug 18, 2023 · 0 comments · Fixed by #1720
Closed
9 tasks

Cleanup web3/rpc/eth type converters #1694

jangko opened this issue Aug 18, 2023 · 0 comments · Fixed by #1720

Comments

@jangko
Copy link
Contributor

jangko commented Aug 18, 2023

Currently web3/rpc/eth type converters are scattered around in many places.
Not all the conversion are written using converters. And they appear ugly.
Duplicates are common. It's time to clean them up and gather them together.
Ugly codes need to be rewritten using proper converters.
New intermediate types may need to be invented, such as RPCReceipt as a complement to regular Receipt/ReceiptObject type.
RPC types also need to be rewritten using saner web3 primitives.

PS: the converter we are talking about here is not Nim converter, but a func or proc.

  • rpc/merge utils
  • engine_api
  • pyspec_sim
  • engine_sim
  • sealer
  • json_rpc_data_source
  • rpc_types
  • rpc_utils
  • execution_types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant