Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPayloadV2 return invalid blockValue #1686

Closed
jangko opened this issue Aug 17, 2023 · 0 comments · Fixed by #1691
Closed

GetPayloadV2 return invalid blockValue #1686

jangko opened this issue Aug 17, 2023 · 0 comments · Fixed by #1691
Labels
bug Something isn't working RPC JSON-RPC over HTTP/websocket txpool tx pool related issue

Comments

@jangko
Copy link
Contributor

jangko commented Aug 17, 2023

The current blockValue calculation is wrong.
According to the spec blockValue is "The expected value to be received by the feeRecipient in wei".

When the block is generated by txPool, the value received by feeRecipient should be recorded, and then retrieved by GetPayloadV2 and blockValue field value.
@jangko jangko added bug Something isn't working RPC JSON-RPC over HTTP/websocket txpool tx pool related issue labels Aug 17, 2023
@jangko jangko mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working RPC JSON-RPC over HTTP/websocket txpool tx pool related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix engine api: getPayload V2 and V3 now returns correct blockValue status-im/nimbus-eth1
1 participant
@jangko