Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txpool should check for too low nonce against sender #1663

Closed
jangko opened this issue Jul 29, 2023 · 1 comment · Fixed by #1672
Closed

Txpool should check for too low nonce against sender #1663

jangko opened this issue Jul 29, 2023 · 1 comment · Fixed by #1672
Labels
bug Something isn't working txpool tx pool related issue

Comments

@jangko
Copy link
Contributor

jangko commented Jul 29, 2023

As shown by graphql simulator test result, txpool allow a tx with too low nonce as valid item.
Need to add tx validation in txpool against tx.sender latest state and reject the invalid tx before evm execution.

@jangko jangko added bug Something isn't working txpool tx pool related issue labels Jul 29, 2023
@jangko
Copy link
Contributor Author

jangko commented Aug 4, 2023

Turn out this is not a txpool bug, but rather a bug in test or nimbus who is using txpool.
Every test and nimbus should inform txpool with latest valid chain head so it can get correct sender state to compare against incoming txs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working txpool tx pool related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant