Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimbus t8n 4844 support #1587

Closed
winsvega opened this issue May 23, 2023 · 4 comments
Closed

Nimbus t8n 4844 support #1587

winsvega opened this issue May 23, 2023 · 4 comments

Comments

@winsvega
Copy link

as nimbus now is getting the best t8n implementation
to make tests around 4844 it would be good to have blob tx support.

in t8n reponse file
"currentExcessDataGas"
in env t8n file
"parentExcessDataGas" (to calculate the formula) or "currentExcessDataGas" (to set the value without formula)

@jangko
Copy link
Contributor

jangko commented Jun 8, 2023

Hai @winsvega , eip-4844 branch is ready for testing. Hope it works well because it's still fresh from the oven

@winsvega

This comment was marked as resolved.

@winsvega
Copy link
Author

winsvega commented Jun 19, 2023

@jangko, found the way to break it.
the code:

[[2]] (BLOBHASH 0xffffffff) ; 32
             [[3]] (BLOBHASH 0xffffffffffffffff)  ; 64
             [[4]] (BLOBHASH 0xffffffffffffffffffffffffffffffff) ; 128
             [[5]] (BLOBHASH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff) ; 256

if I pass the high value to BLOBHASH opcode, the evm fails:
Error: IndexDefect : index -1 not in 0 .. 1

@jangko
Copy link
Contributor

jangko commented Jun 23, 2023

@winsvega , BlobHash bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants