Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uTP sockets still leak in Fluffy #1580

Closed
kdeme opened this issue May 12, 2023 · 1 comment
Closed

uTP sockets still leak in Fluffy #1580

kdeme opened this issue May 12, 2023 · 1 comment
Labels
Fluffy

Comments

@kdeme
Copy link
Contributor

kdeme commented May 12, 2023

After #1075, there still seems to be a uTP socket leak.

Easily reproducible by running Fluffy + glados to trigger FindContent requests. Quickly visible in for example the utp_established_connections metric.

Must be more than just the metric though, as the socket gets deleted in the same call https://github.com/status-im/nim-eth/blob/6e5ee490c2c01faf7982d267201244f4d14ec216/eth/utp/utp_router.nim#L83, TBI.
@kdeme kdeme added the Fluffy label May 12, 2023
@kdeme
Copy link
Contributor Author

kdeme commented Jul 12, 2023

Socket leaks and other utp issues have been fixed with #1604

@kdeme kdeme closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fluffy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme