Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore the possibility of unify process_transaction and tx_packer #1524

Open
jangko opened this issue Mar 28, 2023 · 0 comments
Open

explore the possibility of unify process_transaction and tx_packer #1524

jangko opened this issue Mar 28, 2023 · 0 comments
Labels

Comments

@jangko
Copy link
Contributor

jangko commented Mar 28, 2023

Both process_transaction.nim and tx_packer.nim share a lot of similarities: executing a transaction.
Although they now have differences, maybe we can somehow unify both of them similar to what we have done with various emv call in the past.

The new EIP-1153 and old one like EIP-158/161 proves having two transaction execution increase maintenance cost because we have to modify code in two places rather than only in one place.

tx_packer is less tested compared to process_transaction hence may lead to regression without we being aware of it.

@jangko jangko added txpool tx pool related issue hard labels Aug 17, 2023
@jangko jangko added the EL label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant