-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp-based forking for Shanghai (and later) #1424
Comments
Note also that geth has put in a hard-coded value called timestampThreshold, used to decide whether a forkid.next field is a block number or a timestamp. https://github.com/ethereum/go-ethereum/blob/master/core/forkid/forkid.go#L48 |
in EIP-4895, geth still keep both |
fixed by #1465. closing |
Activation of the Shanghai fork will be determined by a timestamp, not a block number.
e.g. EIP-4895 says, "Beginning with the execution timestamp FORK_TIMESTAMP, execution clients MUST introduce the following extensions to payload validation and processing..."
jangko had some comments here on how to go about implementing this.
The text was updated successfully, but these errors were encountered: