Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forkOverride from test runner and processTransaction #1410

Open
jangko opened this issue Jan 10, 2023 · 0 comments
Open

remove forkOverride from test runner and processTransaction #1410

jangko opened this issue Jan 10, 2023 · 0 comments

Comments

@jangko
Copy link
Contributor

jangko commented Jan 10, 2023

The early general state test is using fork override because at that time there is no proper hard fork management.
It was handy at that time, but now it becomes unnecessarily complicated.

Multiple source of hardfork only cause confusion and maintenance cost.

places where to look at when addressing this issue:

  • test_generalstate_json.nim
  • evmstate tool
  • BaseVMState.fork usage, maybe in evm_call
  • processTransaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant