Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Legacy Sync to sync with available peers instead of waiting for minimal amount of peers after a period of time #1385

Closed
jangko opened this issue Dec 16, 2022 · 1 comment
Labels
Hive Sync Prevents or affects sync with Ethereum network

Comments

@jangko
Copy link
Contributor

jangko commented Dec 16, 2022

Legacy it is, but it still useful to test out experimental features before ported to other sync algorithm.

Current Legacy Sync design requires minimal two peers before syncing started, but the hive test(ethereum/sync) only provide one peers to sync with.

reference implementation starts with min 5 peers before syncing started, but after a period of time passed, and the minimal amount of peers not meet, it will start syncing with available number of peers.

This will require significant amount of work to redesign Legacy Sync. But because other sync algorithm also not ready to participate in hive test, the experiment should be first tested in Legacy Sync.

@jangko jangko added Hive Sync Prevents or affects sync with Ethereum network labels Dec 16, 2022
@tersec
Copy link
Contributor

tersec commented May 30, 2024

Legacy sync was removed: #2237

@tersec tersec closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hive Sync Prevents or affects sync with Ethereum network
Projects
None yet
Development

No branches or pull requests

2 participants