Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Engine API http and ws on the same port #1347

Closed
yorickdowne opened this issue Dec 3, 2022 · 2 comments · Fixed by #1992
Closed

Improvement: Engine API http and ws on the same port #1347

yorickdowne opened this issue Dec 3, 2022 · 2 comments · Fixed by #1992
Labels
hard RPC JSON-RPC over HTTP/websocket

Comments

@yorickdowne
Copy link

For easier configuration and to match every other EL out there, it'd be very helpful if http and ws for the Engine API were on the same port 8551 by default, instead of on 8550 and 8551 respectively.

WS is an upgrade from HTTP after the initial connection.

    --engine-api              Enable the Engine API [=false].
     --engine-api-port         Listening port for the Engine API [=8550].
     --engine-api-address      Listening address for the Engine API [=127.0.0.1,
                               meaning local host only].
     --engine-api-ws           Enable the WebSocket Engine API [=false].
     --engine-api-ws-port      Listening port for the WebSocket Engine API
                               [=8551].
     --engine-api-ws-address   Listening address for the WebSocket Engine API
                               [=127.0.0.1, meaning local host only].
@jangko
Copy link
Contributor

jangko commented Dec 21, 2022

TODO:

  • devise a common HHTP server than can be used by JSON RPC, Graphql, and websocket services.
  • both engine api and ws services need to use common HTTP server instead of it's own HTTP server.
  • detect HTTP upgrade and route the request to ws handler.
  • scan GET/POST path contains /graphql and route the request to graphql handler.
  • request maybe JSON RPC if the ContentType contains application/json, route it to rpc handler.

@jangko jangko added the RPC JSON-RPC over HTTP/websocket label Dec 22, 2022
@jangko jangko added the hard label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hard RPC JSON-RPC over HTTP/websocket
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants