Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimbus t8n 0-touch reward on pre EIP150 networks #1336

Closed
winsvega opened this issue Nov 28, 2022 · 3 comments · Fixed by #1354
Closed

nimbus t8n 0-touch reward on pre EIP150 networks #1336

winsvega opened this issue Nov 28, 2022 · 3 comments · Fixed by #1354
Labels
bug Something isn't working

Comments

@winsvega
Copy link

winsvega commented Nov 28, 2022

Nimbus t8n tool also happen to have this issue:

on pre <=EIP150 networks if coinbase account get 0 mining reward (in state tests, or gasPrice = 0 in blockchain tests)
the account is still expected to be created in the post state as empty

Running test State Diff: (stExample/eip1559, fork: EIP150, TrInfo: d: 0, g: 0, v: 0, TrData: ` :raw 0x00..`) 
{
    "NEW: 0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba" : {
        "code" : "0x",
        "nonce" : "0x00 (0)",
        "balance" : "0x00 (0)",
        "storage" : {
        }
    }
}

nimbust t8n tool didn't put an account.

@jangko jangko added the bug Something isn't working label Nov 29, 2022
@jangko
Copy link
Contributor

jangko commented Dec 7, 2022

@winsvega: can you share your test vector with me? I have difficulty to reproduce it

@winsvega
Copy link
Author

winsvega commented Dec 7, 2022

Here is the Nimbus log.
https://justpaste.it/ceztv

the transaction that comes is invalid. this is experimental test to check exceptions of rlp transaction sturctures in state tests too. the transaction supposed to be rejected with exception and the mine_block just seals an empty block.

@jangko
Copy link
Contributor

jangko commented Dec 8, 2022

Thanks, it really helpful. Now I'm able to understand the problem

@jangko jangko mentioned this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants