Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the standadized CLI for execution state transition tests #1262

Closed
zah opened this issue Oct 14, 2022 · 6 comments
Closed

Implement the standadized CLI for execution state transition tests #1262

zah opened this issue Oct 14, 2022 · 6 comments
Assignees

Comments

@zah
Copy link
Contributor

zah commented Oct 14, 2022

https://ethereum-tests.readthedocs.io/en/latest/t8ntool-ref.html is a document describing a standard command-line interface for executing state transition tests. There are third party testing teams interested in including Nimbus in their testing efforts, but their existing tooling is based on this standardized interface.

@zah
Copy link
Contributor Author

zah commented Oct 14, 2022

cc @winsvega

@jangko
Copy link
Contributor

jangko commented Oct 26, 2022

I've implemented the state transition tool in PR #1279. And here is the build instructions:
https://github.com/status-im/nimbus-eth1/tree/master/tools/t8n

cc @winsvega

@jangko jangko closed this as completed Oct 26, 2022
@winsvega
Copy link

Thanks, I will check it out

@winsvega
Copy link

winsvega commented Nov 22, 2022

please support

--state.reward -1

for genesis state hash calculation (to calculate given state hash without any 0, or non 0 mining rewards)

Thanks a lot lets see which tests do yo pass. but first I need this option. we recently discoverd a bug in the tests that lead to coinbase account not being present in the state with 0 reward touch. (pre EIP150) rules. but this also means that when I calculate genesis state hash, I don't need coinbase account touch on pre EIP150 rules. so -1 means just calculate the stateRootHash of the given state. which I use to process genesis.

@winsvega
Copy link

I put it here #1313

@winsvega
Copy link

can't update nimbus. make command fails:

make update
Git submodules not found. Running 'git submodule update --init --recursive'.

fatal: No url found for submodule path 'vendor/nim-snappy/tests/snappycpp/third_party/benchmark' in .gitmodules
Failed to recurse into submodule path 'vendor/nim-snappy/tests/snappycpp'
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-bearssl/bearssl/csources' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-blscurve/vendor/blst' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-libbacktrace/vendor/libbacktrace-upstream' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-nat-traversal/vendor/libnatpmp-upstream' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-secp256k1/secp256k1_wrapper/secp256k1' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-snappy/tests/snappycpp' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nim-zlib/zlib/csources' in .gitmodules
fatal: No url found for submodule path 'vendor/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim' in .gitmodules
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-bearssl'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-blscurve'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-libbacktrace'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-nat-traversal'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-secp256k1'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-snappy'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nim-zlib'
Failed to recurse into submodule path 'vendor/nimbus-eth2/vendor/nimbus-build-system'
Failed to recurse into submodule path 'vendor/nim-snappy'
Failed to recurse into submodule path 'vendor/nimbus-eth2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants