Address issue loading all subtitles #2987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue preventing all subtitles from getting loaded. For whatever reason, when I was debugging yesterday, my breakpoint in
(sceneRoutes).CaptionLang()
was only getting hit once. Today when debugging, I was actually getting into CaptionLang for each language which led me to discover that during the refactor a return statement was mistakingly used within the for loop in(sceneRoutes).Caption()
preventing us from reading subtitles past the first index.