Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apple touch icon #2295

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

cj12312021
Copy link
Collaborator

I assume the ui/v2.5 directory is the correct place to put this icon. Let me know if it needs to be moved.

@kermieisinthehouse
Copy link
Collaborator

Can you post screenshots of what this looks like in context, before and after?

Also, note that static assets are now generated from a master icon using https://github.com/stashapp/stash/blob/develop/scripts/generate_icons.sh

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Feb 8, 2022

I, unfortunately, haven't set up a proper local dev environment yet which is why I've been tackling more minor items like this. Hopefully, by the end of this week, my environment will be set up. Until then all I can provide for now is a reference to metart.com and how they currently handle this as well as what it looks like on my phone.
Screenshot 2022-02-07 184225
unnamed

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Feb 10, 2022

I just got around to setting up my environment. here are the screenshots:
IMG-1250

IMG-1251
This image on the far left is the stash icon from the release build. The image on the far right is stash using my current change.

@kermieisinthehouse
Copy link
Collaborator

Using favicon.png doesn't work for you?

@cj12312021
Copy link
Collaborator Author

It does. The background with the favicon.png is just pitch black. I'll revert my change and get a screenshot. Give me a sec

@cj12312021
Copy link
Collaborator Author

IMG-1252

IMG-1253
The favcon.png isn't bad. I just don't think it's a proper icon.

@kermieisinthehouse
Copy link
Collaborator

Hmm, I can't find any way to set the background color dynamically. Having a dedicated one seems to be the way to go. Can you rename it apple-touch-icon.png to meet the standard?

@bnkai bnkai added the ui Issues related to UI label Feb 10, 2022
@cj12312021
Copy link
Collaborator Author

Hey Kermie, just wanted to make sure you weren't waiting on me for anything else regarding this pr

@WithoutPants WithoutPants added this to the Version 0.13.0 milestone Feb 16, 2022
@WithoutPants WithoutPants merged commit 7336a6c into stashapp:develop Feb 16, 2022
@cj12312021 cj12312021 deleted the update_apple-touch-icon branch February 17, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants