Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict forward() does not use lm in kwargs #1167

Closed
Ruce opened this issue Jun 18, 2024 · 2 comments
Closed

Predict forward() does not use lm in kwargs #1167

Ruce opened this issue Jun 18, 2024 · 2 comments

Comments

@Ruce
Copy link

Ruce commented Jun 18, 2024

In the Predict class, the forward function sets the local variable lm from kwargs (line 71), but this lm is not used in generating output. The assignment should be to self.lm instead so that it works with the block in lines 102-108.

@arnavsinghvi11
Copy link
Collaborator

Thanks for raising this @Ruce ! This is related to #774 if you'd like to follow for updates.

@okhat okhat closed this as completed Jun 27, 2024
@okhat
Copy link
Collaborator

okhat commented Jun 27, 2024

closing in favor of the other issue, we're exploring this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants