Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiChainComparison input from ChainOfThought #1162

Closed
Bobsimonoff opened this issue Jun 17, 2024 · 3 comments
Closed

MultiChainComparison input from ChainOfThought #1162

Bobsimonoff opened this issue Jun 17, 2024 · 3 comments

Comments

@Bobsimonoff
Copy link

Maybe I am missing the short cut:

ChainOf thought, where n=4, returns a Prediction, which has a single rationale, a single answer, and a Completions object. The completions object has an array of 3 strings for the rationale and an array of 3 strings for the answer.

The MultiChainComparison however takes an array of Predictions.

Wouldn't it be more natural for MultiChainComparison to accept the output Predictions object or the Completions object rather than forcing the caller to reformat ChainOfThought's output to comply with MultiChainComparison's input?

Also, if n=4, shouldn't there be 4 completions not 3?

@arnavsinghvi11
Copy link
Collaborator

Hi @Bobsimonoff ,

I believe the current logic just requires that additional step of creating dspy.Prediction objects, but this makes sense and would be great to add to MultiChainComparison via a PR.

As for the number of outputted completions, I believe it has to do with the generation extension logic where if the produced completion is deemed incomplete (missing the corresponding output fields), it is not included in the final set of completions - relevant PR #920.

@Bobsimonoff
Copy link
Author

Thanks @arnavsinghvi11 for your response ... so n really means up to the requested number of responses, not n responses. Didn't realize that,

@arnavsinghvi11
Copy link
Collaborator

Tagging the discussion here if you'd like to follow. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants