Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StanfordCoreNLPServer ignores parse.maxlen and pos.maxlen properties #186

Closed
klopyrev opened this issue May 9, 2016 · 1 comment
Closed

Comments

@klopyrev
Copy link

klopyrev commented May 9, 2016

It seems like there's an extra negation in the following lines: https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/pipeline/StanfordCoreNLPServer.java#L572

It should be "-1".equals(props.getProperty("parse.maxlen", "60")), not !"-1".equals(props.getProperty("parse.maxlen", "60"))

@gangeli @muzny

@gangeli
Copy link
Member

gangeli commented May 10, 2016

So, if I recall this was put in after the Great Hacker News [Unintentional] DDOS Of 2016, where we got a bunch of concurrent requests to the service on our little 4-core machine, and I was trying to keep users from putting in sentences that would cause the parser to take forever. Now that we have timeouts implemented a bit more carefully, this should actually be unnecessary altogether. I've removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants