Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_route53.py unable to handle subdomains #418

Open
marrek-az opened this issue Jul 13, 2019 · 3 comments
Open

dns_route53.py unable to handle subdomains #418

marrek-az opened this issue Jul 13, 2019 · 3 comments
Assignees
Labels
Projects

Comments

@marrek-az
Copy link

marrek-az commented Jul 13, 2019

This is similar to #398. If you have a Route53 hosted zone example.com and one for foo.example.com with NS record handling the delegation, and you try to obtain a certificate for www.foo.example.com, the dns_route53.py script will look in the zone for example.com, not foo.example.com. A stricter check of zone names would prevent this.

@marrek-az
Copy link
Author

Ironically, changing reverse=True to reverse=False on line 34 appears to correct the problem, at least in my simple scenario.

@QuingKhaos QuingKhaos self-assigned this Sep 30, 2019
@QuingKhaos QuingKhaos added the bug label Sep 30, 2019
@QuingKhaos QuingKhaos added this to Needs triage in bugfix via automation Sep 30, 2019
@QuingKhaos QuingKhaos moved this from Needs triage to Low priority in bugfix Sep 30, 2019
@QuingKhaos
Copy link
Collaborator

I guess #399 will not resolve your issues, as the check only looks on whole parts on the incoming zone names now. May you test?

@marrek-az
Copy link
Author

This issue still exists. If you have zones in route53 for example.com and foo.example.com and you try to use this to obtain a certificate for bar.foo.example.com, it will loop forever with Didn't find _acme-challenge.bar.foo.example.com entry yet, sleeping...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
bugfix
  
Low priority
Development

No branches or pull requests

3 participants