-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns_route53.py unable to handle subdomains #418
Comments
Ironically, changing reverse=True to reverse=False on line 34 appears to correct the problem, at least in my simple scenario. |
I guess #399 will not resolve your issues, as the check only looks on whole parts on the incoming zone names now. May you test? |
This issue still exists. If you have zones in route53 for example.com and foo.example.com and you try to use this to obtain a certificate for bar.foo.example.com, it will loop forever with Didn't find _acme-challenge.bar.foo.example.com entry yet, sleeping... |
This is similar to #398. If you have a Route53 hosted zone example.com and one for foo.example.com with NS record handling the delegation, and you try to obtain a certificate for www.foo.example.com, the dns_route53.py script will look in the zone for example.com, not foo.example.com. A stricter check of zone names would prevent this.
The text was updated successfully, but these errors were encountered: