-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible problems with linode dns add/del scripts #292
Comments
I wrote a script to address these possible problems. To keep it out of the way of the existing scripts, I link dns-add-linode and dns-del-linode to this script. (.txt extension to allow me to attach.) |
Thanks - I've been away / busy for a while - I'll try and catch up with the backlog of issues / PR's here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that the dns_add_linode and dns_del_linode scripts assume that the base of the dns name is always two components long. This is not true for most national dns domains ouside the US. For example, com.au, net.au, org.au etc.
I don't know whether this will matter in practice, but it would seem a better idea to match a request domain against domain record with the longest trailing substring of the request domain. For example, if the DNS server returns records for domains b.a and c.b.a, and the request domain is d.c.b.a, then the challenge should be associated with the c.b.a record.
I have no idea whether such situations occur in practice.
Another possible problem is with the delete script. It is possible for multiple identical TXT records to be present, differeing only in the resourceid.d When deleting such a resource, would it not be desirable to remove all of the mathing TXT resources?
The text was updated successfully, but these errors were encountered: