Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_*_nsupdate sample scripts are broken, and a bad example #290

Open
tlhackque opened this issue May 15, 2017 · 0 comments
Open

dns_*_nsupdate sample scripts are broken, and a bad example #290

tlhackque opened this issue May 15, 2017 · 0 comments

Comments

@tlhackque
Copy link
Contributor

As noted in #286, the dns_add/del_update sample scripts leave a lot be be desired.
Further investigation found more issues; here is the complete list:

  • They are inefficient - use unnecessary temp files
  • They require a custom copy of the script for each instance
  • The exit status of nsupdate is clobbered by the rm of the tempfile; they never fail
  • There is no provision for pre/post processing (e.g. decrypt a key file or mount a disk containing it)

I've rewritten them; there'll be a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant