From 0c4461ecb7cf59f03b857e469f8ac6bbcd258d50 Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Thu, 30 Apr 2020 01:37:22 -0600 Subject: [PATCH] tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior (#7709) Signed-off-by: Brian Anderson --- .../tidb_query/src/batch/executors/slow_hash_aggr_executor.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/tidb_query/src/batch/executors/slow_hash_aggr_executor.rs b/components/tidb_query/src/batch/executors/slow_hash_aggr_executor.rs index cbb73ea97f2..a1c2905bb2a 100644 --- a/components/tidb_query/src/batch/executors/slow_hash_aggr_executor.rs +++ b/components/tidb_query/src/batch/executors/slow_hash_aggr_executor.rs @@ -279,7 +279,6 @@ impl AggregationExecutorImpl for SlowHashAggregationImp )?; } - let buffer_ptr = (&*self.group_key_buffer).into(); for logical_row_idx in 0..logical_rows_len { let offset_begin = self.group_key_buffer.len(); @@ -363,6 +362,7 @@ impl AggregationExecutorImpl for SlowHashAggregationImp } } + let buffer_ptr = (&*self.group_key_buffer).into(); // Extra column is not included in `GroupKeyRefUnsafe` to avoid being aggr on. let group_key_ref_unsafe = GroupKeyRefUnsafe { buffer_ptr,