Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createMatteTheme expecting an argument #49

Open
ksiabani opened this issue Dec 23, 2021 · 0 comments
Open

Fix createMatteTheme expecting an argument #49

ksiabani opened this issue Dec 23, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@ksiabani
Copy link
Collaborator

ksiabani commented Dec 23, 2021

The createMatteTheme utility is used to provide a MUI-based theme. It is the same as MUI's createTheme but it is extended to include theming for Nivo charts. The createMatteTheme expects an argument, but it should let the users pass none, in which case a default theme is used.

How to reproduce

  • In a TS project that uses Matte, try to create at theme:
    const theme = createMatteTheme();.
  • You will get the following warning:
    Expected 1 arguments, but got 0.ts(2554)

Acceptance criteria

You shouldn't get the warning when creating a theme like this, instead the default theme should be applied without warning.

@ksiabani ksiabani added bug Something isn't working good first issue Good for newcomers needs analysis Further analysis is needed labels Dec 23, 2021
@ksiabani ksiabani added this to the Version 1 milestone Dec 23, 2021
@ksiabani ksiabani removed the needs analysis Further analysis is needed label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant