Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Matte icon-library agnostic #43

Open
5 tasks
ksiabani opened this issue Dec 23, 2021 · 0 comments
Open
5 tasks

Make Matte icon-library agnostic #43

ksiabani opened this issue Dec 23, 2021 · 0 comments
Milestone

Comments

@ksiabani
Copy link
Collaborator

ksiabani commented Dec 23, 2021

At the moment, Matte is based on the library React-feather to show icons in some of its components. As a result:

  • React-feather library is installed as a dependency to every project that Matte is installed
  • People cannot use their own icon libraries, hence a design inconsistency occurs

What to do?

IMO we should:

  1. Let people pass their own icons as props, and
  2. Use SVG equivalents as defaults when people don't want to pass their own icons
  3. For cases where an X icon is used as a way to close a window the × equivalent may be used (see implementation for Dialog component for this)

Who uses it at the moment?

See the list above to check the progress of replacing Feather icons:

@ksiabani ksiabani added this to the Version 1 milestone Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant