Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedSource.readUByte etc. #513

Open
swankjesse opened this issue Sep 23, 2018 · 3 comments · May be fixed by #536
Open

BufferedSource.readUByte etc. #513

swankjesse opened this issue Sep 23, 2018 · 3 comments · May be fixed by #536
Assignees
@bnorm
Labels
enhancement
Milestone
Backlog

Comments

@swankjesse
Copy link
Member

https://blog.jetbrains.com/kotlin/2018/08/kotlin-1-3-m2/
@swankjesse swankjesse added this to the 2.1 milestone Sep 23, 2018
@JakeWharton
Copy link
Member

Would be nice if these were inline extension functions on reading a signed value and then "wrapping" it. That makes them zero overhead instead of actually requiring additional methods on the interface.

@swankjesse
Copy link
Member Author

swankjesse commented Sep 23, 2018 •
edited
Loading

Definitely. Plus that prevents us from cluttering the Java API.

@swankjesse swankjesse modified the milestones: 2.1, 2.2 Sep 23, 2018
@bnorm
Copy link
Collaborator

bnorm commented Nov 9, 2018

I'll look into this one unless there are any objections.

@bnorm bnorm self-assigned this Jan 22, 2019
@bnorm bnorm linked a pull request Jan 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnorm bnorm

Labels
enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Unsigned numbers in Okio bnorm/okio
3 participants
@JakeWharton @swankjesse @bnorm