Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically add @ApiImplicitParam.dataType class references to models #2

Open
zyro23 opened this issue Jan 15, 2017 · 2 comments
Open
Labels

Comments

@zyro23
Copy link

zyro23 commented Jan 15, 2017

if @ApiImplicitParam.dataType references a non-simple type (i.e. a custom class), you also need to reference that class via Docket.additionalModels. would make sense to do that automatically, i think.

@dilipkrish
Copy link
Member

@zyro23 thanks for reporting. The only issue with that is that there is no guarantee that that class is in the class path or that there is only one class with that name (different package).

@zyro23
Copy link
Author

zyro23 commented Jan 15, 2017

what about supporting a fqcn? dataType = "my.package.MyClass"
swagger-servlet behavior for reference:
ref. https://github.com/swagger-api/swagger-core/blob/v1.5.12/modules/swagger-servlet/src/main/java/io/swagger/servlet/extensions/ServletReaderExtension.java#L419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants